Holly mother of... Mark Estes has done fantastic work with his ledtable code.

Archive FastLED Archive
,
1

Holly mother of… @Mark_Estes has done fantastic work with his ledtable code.

[8 new photos · Album by Marc MERLIN] Mark Estes ledtable

I just spent the last 4H going through it after making it work on my simpler matrix (without teensy, audio, SPI, or octows parallel output).
Mark, I found a couple of small bugs while enabling compiler warnings against your code: https://github.com/marcmerlin/Table_Mark_Estes/commit/2ff651d59f5fa83fbf944a0f3dde5bb1a4529346
I also added serial support to select next/prev/demo number:
https://github.com/marcmerlin/Table_Mark_Estes/commit/8a5a1b451ae20898d15b45e61de222bb57cf172a
You can now enter ‘n’, ‘p’, or ‘101’ to jump to a given demo directly.

And for all: the number of demos. 112! Yes, 112 demos! I’m not even going to ask how long it took to write them.
Second, most of them are written to adapt to the matrix size and worked out of the box on my 24x32 matrix. A few will have to be fixed, but many just worked.

I put my fork of Mark’s code here: https://github.com/marcmerlin/Table_Mark_Estes
@Mark_Estes please let me know which license you intended for this code. If you don’t know or care, can you grant me an Apache2 license? (typical license that offers protection to you while allowing pretty much any use of the code).
I’ll add the license in my github after you confirm.
If you give me your Email or other info you’d like me to add in the README, I’ll be happy to add whatever you’d like (you can Email me at marc http://merlins.org).
I usually post a video along with the code, but this would be a 45mn video maybe. I’m going to have to think how to do it :slight_smile:

0bf05524a7ce1d5181743cfed6bbba55.jpeg
0bf05524a7ce1d5181743cfed6bbba55.jpeg3024×4032 1.87 MB

25ca17517f3cd43ff151295c383c942e.jpeg
25ca17517f3cd43ff151295c383c942e.jpeg3024×4032 1.59 MB

e3035abc6870f36291f7995dd9e3d267.jpeg
e3035abc6870f36291f7995dd9e3d267.jpeg3024×4032 1.78 MB

2c0d896df08ce724e5660d6562017c71.jpeg
2c0d896df08ce724e5660d6562017c71.jpeg3024×4032 1.82 MB

8435fe02093b44a64600f223db651c44.jpeg
8435fe02093b44a64600f223db651c44.jpeg3024×4032 1.8 MB

c39883256484bb910db2b5b898e39d54.jpeg
c39883256484bb910db2b5b898e39d54.jpeg3024×4032 1.91 MB

24846bd4cfe5bff5763f61cf94819e0b.jpeg
24846bd4cfe5bff5763f61cf94819e0b.jpeg3024×4032 1.74 MB

2

very nice of you to do this. I have added a few new patterns but nothing too striking.

3

You found legit bugs. Most of those had worked their way out of the code already. a few of the “MIDLX>>” events still needed a pair of () to keep the math clean. The last bug, was a bug but I believe the intent was for i to start with 1, not zero.

faudio[0] = random(1, MIDLY);
for (byte i = 1; i < MATRIX_WIDTH; i++) {

4

Thanks @Mark_Estes I’ve changed it back to byte i = 1 , of course I don’t want to overwrite the previously written value.
I was still seeing a stray pixel 0 set to high green on any audio related demo though. It’s not pixel[0,0] that gets overwritten, but zed[0] which on my matrix is the 8th pixel from the left on top.
I then found that it was all the digitalWrite(12, HIGH); that happened to be writing to my matrix, so I removed them. Now the stray pixel is gone :slight_smile:
Back to the license, are you ok if I add an Apache2 license along with your code, and would you like me to credit you further in a README?

5

Apache2 is fine. Thanks