I took a quick look at the github commits but didn’t see anything glaring. I wanted to let you know that I updated to the latest 2.1 branch so that I could test the new color palette code (woohoo!).
Unfortunately, I discovered that there is some change that occurred between the 5/11 build and now that my P9813 project doesn’t like at all. With the newest build, (and this is once again a bit difficult to explain) only about half of my 576 LED string is getting correct data. Everything else to the end of the string is getting random colors and brightness (or sometimes not even changing at all).
Another way to put this is that the left half of patterns on my 24 x 24 array look good, and they change to new patterns (indicating that the code is still running), but the right side is jumbled. I changed back to the 5/11 build and reloaded and then everything was working as expected.
Assuming I can figure out how to do this with github (I’m still pretty new to github, but I think I know how), I’m going to check out newer and newer versions of the code to see if I can identify the specific commit where things broke.
Thank you for the report, and please let us know what you find. Obviously, we’re interesting in finding and fixing any bugs ASAP.
If I did my testing correctly (and I was pretty careful, so I think I’m right), this is the commit where things broke. In looking at the changes, this seems plausible, as Daniel was making SPI-related changes (and some stuff related to the Teensy which is what I’m using) and based on my past experience, this felt like it might be an SPI issue.
https://github.com/FastLED/FastLED/commit/36bc6b94e6e09cd5fdb653e1b0b9a12d22f6e92a
Thank you VERY much for helping track this down!
Dan’s offline this weekend but I’m sure he’ll be grateful for the report too. Sorry to tangle your project; we’ll do what we can to get you back up and running with the latest goodies.
Thanks very much again.
With all the hard work that you and Dan put into this library, I’m more than happy to help with things like this! My project is back to working - it just means that I’ll have to hold on a little bit longer before being able to play with the color palette functionality.
Whenever Dan has something ready, I’ll give it a good test!
With SPI chipsets, it’s important you let us know which pins you are using - as that shifts whether hardware or bit banging is being used.
Good point! I’m on a Teensy 3.1 using pin 11 for data and pin 13 for clock.
As I continue learning github, I got to thinking. Is there a formal bug reporting mechanism available? If so, should I use that to report issues like this?
Yep. For strictly inside-the-library problems we do use the github issue tracking. Please feel free to open an issue for this; it’ll mostly likely get looked at after the 4th of July weekend, due to massive project work that Dan’s doing “Priceless.”
Thanks Mark. I’m not in any hurry. I know that at work I need to get issues (software or otherwise) in a tracking system of some kind if I have any hope of eventually getting to it
so I figured it would probably help you guys as well. Now I’ll go off to figure out issue tracking with github!